Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ubuntu noble 24.04 fails due to regex #4245

Open
bdellegrazie opened this issue Nov 8, 2024 · 1 comment · May be fixed by #4246
Open

ubuntu noble 24.04 fails due to regex #4245

bdellegrazie opened this issue Nov 8, 2024 · 1 comment · May be fixed by #4246

Comments

@bdellegrazie
Copy link

bdellegrazie commented Nov 8, 2024 •
edited
Loading

Hi,

When testing with Ubuntu 24.04 the nodes fail to install the runner due to the following line:

terraform-aws-github-runner/modules/runners/templates/install-runner.sh

Line 45 in 52ce9c1

os_id=$(awk -F= '/^ID/{print $2}' /etc/os-release)

Specifically, the condition:

os_id=$(awk -F= '/^ID/{print $2}' /etc/os-release)

On Ubuntu 24.04, the source file (/etc/os-release) looks something like:

ID=ubuntu
ID_LIKE=debian

which results in os_id having a value of:

ubuntu
debian

The correct expression is simply:

os_id=$(awk -F= '/^ID=/{print $2}' /etc/os-release)

I'll raise a PR.
@bdellegrazie bdellegrazie linked a pull request Nov 8, 2024 that will close this issue
Open
@ay0o
Copy link

ay0o commented Nov 11, 2024

Related to #4178

bdellegrazie added a commit to bdellegrazie/terraform-aws-github-runner that referenced this issue Nov 13, 2024
@bdellegrazie
fix(runner-install): correct detection of Ubuntu 24.04
42f9848 
On Ubuntu 24.04 there is another variable `ID_LIKE` that appears in
the `/etc/os-release` file. This change fixes the regex match
to only match ID and not ID_LIKE

closes philips-labs#4245
bdellegrazie added a commit to bdellegrazie/terraform-aws-github-runner that referenced this issue Nov 27, 2024
@bdellegrazie
fix(runner-install): correct detection of Ubuntu 24.04
5cb7209 
On Ubuntu 24.04 there is another variable `ID_LIKE` that appears in
the `/etc/os-release` file. This change fixes the regex match
to only match ID and not ID_LIKE

closes philips-labs#4245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(runner): support Ubuntu 24.04 bdellegrazie/terraform-aws-github-runner
2 participants
@bdellegrazie @ay0o