chore: remove deprecated runners_scale_up_Lambda_memory_size as it breaks CDKTF #4276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanrusu-loctax
changed the title
npalm
reviewed
Nov 20, 2024
| @@ -21,14 +21,6 @@ variable "enable_event_rule_binaries_syncer" { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| # tflint-ignore: terraform_naming_convention | |||
There was a problem hiding this comment.
This should remove as part of breaking release. I am planning one soon to remove all deprecated vars. And remove the fifo queues as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Thanks for this module.
I come from a CDKTF shop. CDKTF basically has a code generator based on the HCL code which generates the appropriate objects and types.
TypeScript uses camel case as default convention for symbols so that code generator produces invalid code as both the current
runners_scale_up_lambda_memory_sizeand the legacyrunners_scale_up_Lambda_memory_sizeare converted to the same camel cased string and the TypeScript compiler rejects that code when imported as it contains duplicate symbols.Removing this deprecated variable enables the CDKTF users who run into this problem to successfully use this module.
This is a breaking change but I don't know for how long you do keep deprecated vars.