Skip to content

Commit

Permalink
[580] fix: Console Client couldn't load configuration file correctly …
Browse files Browse the repository at this point in the history
…(introduced by #564) (#584)
  • Loading branch information
philosowaffle authored Dec 31, 2023
1 parent 75733a2 commit 639a719
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
4 changes: 2 additions & 2 deletions mkdocs/docs/configuration/json.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ This section provides settings related to fetching workouts from Peloton.
| Field | Required | Default | UI Setting Location | Description |
|:-----------|:---------|:--------|:--------------------|:------------|
| Email | **yes** | `null` | `Peloton Tab` | Your Peloton email used to sign in |
| Password | **yes** | `null` | `Peloton Tab` | Your Peloton password used to sign in |
| Password | **yes** | `null` | `Peloton Tab` | Your Peloton password used to sign in. **Note: Does not support `\` character in password** |
| NumWorkoutsToDownload | no | 5 | `Peloton Tab` | The default number of workouts to download. See [choosing number of workouts to download](#choosing-number-of-workouts-to-download). Set this to `0` if you would like P2G to prompt you each time for a number to download. |
| ExcludeWorkoutTypes | no | none | `Peloton Tab` | A comma separated list of workout types that you do not want P2G to download/convert/upload. See [example use cases](#exclude-workout-types) below. |

Expand Down Expand Up @@ -251,7 +251,7 @@ This section provides settings related to uploading workouts to Garmin.
| Field | Required | Default | UI Setting Location | Description |
|:-----------|:---------|:--------|:--------------------|:------------|
| Email | **yes - if Upload=true** | `null` | `Garmin Tab` | Your Garmin email used to sign in |
| Password | **yes - if Upload=true** | `null` | `Garmin Tab` | Your Garmin password used to sign in |
| Password | **yes - if Upload=true** | `null` | `Garmin Tab` | Your Garmin password used to sign in. **Note: Does not support `\` character in password** |
| TwoStepVerificationEnabled | no | `false` | `Garmin Tab` | Whether or not your Garmin account is protected by Two Step Verification |
| Upload | no | `false` | `Garmin Tab` | `true` indicates you wish downloaded workouts to be automatically uploaded to Garmin for you. |
| FormatToUpload | no | `fit` | `Garmin Tab > Advanced` | Valid values are `fit` or `tcx`. Ensure the format you specify here is also enabled in your [Format config](#format-config) |
Expand Down
4 changes: 2 additions & 2 deletions src/Common/Configuration.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ public static void LoadConfigValues(IConfiguration provider, Settings config)
{
provider.GetSection(nameof(App)).Bind(config.App);
provider.GetSection(nameof(Format)).Bind(config.Format);
provider.GetSection(nameof(PelotonSettings)).Bind(config.Peloton);
provider.GetSection(nameof(GarminSettings)).Bind(config.Garmin);
provider.GetSection("Peloton").Bind(config.Peloton);
provider.GetSection("Garmin").Bind(config.Garmin);
}

public static void LoadConfigValues(IConfiguration provider, AppConfiguration config)
Expand Down
5 changes: 5 additions & 0 deletions vNextReleaseNotes.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
## Fixes

- [#581] Fix broken Documentation link in UI
- [#580] Console Client couldn't load configuration file correctly (introduced by #564)

## Docs

- [#521] Called out that `\` special character is not currently supported in passwords

## Docker Tags

Expand Down

0 comments on commit 639a719

Please sign in to comment.