Improved user viewer #40
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a picture showing how the page looks like when actually modifying the user :p |
petterroea
requested changes
Jul 9, 2024
HenrikEngen
added a commit
that referenced
this pull request
Aug 4, 2024
HenrikEngen
added a commit
that referenced
this pull request
Aug 4, 2024
… of the name is first- and lastname as mentioned in #40
HenrikEngen
force-pushed
the
feature/improvedUserView_2
branch
from
8e49611 to
52accb5
Compare
HenrikEngen
added a commit
that referenced
this pull request
Aug 4, 2024
HenrikEngen
added a commit
that referenced
this pull request
Sep 19, 2024
HenrikEngen
added a commit
that referenced
this pull request
Sep 19, 2024
HenrikEngen
added a commit
that referenced
this pull request
Sep 19, 2024
HenrikEngen
added a commit
that referenced
this pull request
Sep 25, 2024
HenrikEngen
added a commit
that referenced
this pull request
Sep 25, 2024
… of the name is first- and lastname as mentioned in #40
HenrikEngen
added a commit
that referenced
this pull request
Sep 25, 2024
HenrikEngen
added a commit
that referenced
this pull request
Sep 25, 2024
HenrikEngen
added a commit
that referenced
this pull request
Sep 25, 2024
HenrikEngen
added a commit
that referenced
this pull request
Sep 25, 2024
* positions.jsx has been changed. * Merged the two previous tables together (Current positions and previous positions). * Changed table layout to include information from both previous tables. * Added a icon to indicate that the position is permanent and cant be removed. * Added a delete position confirmation window if you accidently click on the position. * details.jsx has been changed. * Polished the layout. * Added new components to dashboard.jsx.
* Remade and polished the position viewer. * Added card for Discord in viewer/externalConnections.jsx. * Removed unused imports from viewer/details.jsx. * Small changes to labels in viewer/details.jsx. * Fixed imports in viewer/index.jsx. * Minor changes to unrelated file agenda/index.jsx. * Minor changes to utils/user.jsx. * Minor changes to dashboard.jsx. * Updated package related files.
* Changed logic in positions.jsx to fix the loading bug. * Changed all checks from two equal symbols to three.
* Added search/filter, and sorting in user/list.jsx. * Added age in birthdate in user/details.jsx. * Changed padding for InputSelect to match height of other input elements.
* Added .toLowerCase() to input to prevent zero results when writing capitalized characters.
* Changed logic in positions.jsx to fix the loading bug. * Changed all checks from two equal symbols to three.
* Added a windowManager as a global component, to replace the old window system which was created per page. * Added UI for editing users, the new windowManager is being used. Developed in API and JS in the feature/editUser branch. * Added UI for activiating users, the new windowManager is being used. Not developed in API and JS yet. * windowManager is a parent/root component in src/container/index.jsx * minor changes to dashboard.jsx to fix mobile and tablet views, added new components. * minor changes to theme.js, added more colors. + windowManager will replace the old window system when creating and editing agenda entries. + windowManager will replace the old window system when confirming deleting temporary roles from a user in user/positions.
…ic to user details view to handle errors and lack of permissions.
* Described code * Minor changes to notice.jsx styling * Changed code logic in user/viewer/index.jsx * Added errorhandling in user/viewer/index.jsx if authenticated user is unable to view requested user.
* Added pre- and postfunctions in the new windowManager * Added visible property to <Notice />to easilier control when it should show or not. * Added error handling to editUserDetails.jsx * Added refresh logic when you are modifing a user in details.jsx (postFunctions) * Added a icon to show when a role is active for a user not, and added windowManager in user/viewer/positions.jsx. * Changed styling for border-bottom in <WindowContentHeaderContainer /> * Changed deletePosition.jsx window to use the new windowManager.
…rom master because I overwrote it.
…or Input components.
…nfirm function. Affects activateUser, deleteAvatar, deletePosition, editUser. Moved the logic mentioned above to their actual files.
…de, fixed logic, etc.
…and memberList.jsx, added position details.jsx, added and modified components in dashboard.jsx, added new colors in theme.js
HenrikEngen
force-pushed
the
feature/improvedUserView_2
branch
from
a7283f2 to
738ef7e
Compare
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
… of the name is first- and lastname as mentioned in #40
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
… of the name is first- and lastname as mentioned in #40
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
HenrikEngen
added a commit
that referenced
this pull request
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a problem where modifyUser doesnt work, but this will be solved as soon as phoenixjs gets updated.
Todos from issue #10:
Dependencies:
Required because this version of the improved user view has modify user functionality that wont work without this phoenixAPI code.
Required because this version of the improved user view has modify user functionality that wont work without this phoenixJS code.
Pictures: