-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
6 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
558fd52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When can this be released?
558fd52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nyholm any update?
558fd52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Released!
=)
558fd52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @Nyholm !
This may be pushing my luck, but would it be possible to allow
psr/cache ^3.0
too?It's because the Auth0 login package
auth0/login
requires^3.0
minimum now..558fd52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, that is a BC break. I cannot support psr/cache ^3.0 without a new major version.
The Fig suggest to make auth0/login require
^2.0 || ^3.0
Your alternative is to look at symfony/cache
558fd52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see,
auth0/login
is going to stick with^3.0
because of some other upstream dependencies.Thanks for your note regarding
symfony/cache
, I'll take a look into it.(Or, how much in terms of 💰or ☕️ for a new major version? 😆)
558fd52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you send your 💰or ☕️ better on looking into
symfony/cache
. It is actively maintained. And it is a full community behind it with way more smarted people than me.It also has some cool feature that php-cache does not support. Ie stampede protection.
558fd52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, thank you for your time and work on this package! 😊