Skip to content

Webpack HMR compatibility: update editInPlace.js #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Webpack HMR compatibility: update editInPlace.js #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
735c848
Update editInPlace.js
neothone Jul 20, 2025
c49be6b
Update DefaultApplyingNodeVisitor.php
neothone Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Resources/public/js/editInPlace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@
// it is not possible to use HTMLElement directly
class XTrans extends HTMLElement {}

customElements.define("x-trans", XTrans);

if (!customElements.get('x-trans')) {
customElements.define("x-trans", XTrans);
}

return;
}

Expand Down
2 changes: 0 additions & 2 deletions Twig/Visitor/DefaultApplyingNodeVisitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ public function enterNode(Node $node, Environment $env): Node

$expr = new EqualBinary($testNode, $transNode->getNode('node'), $wrappingNode->getTemplateLine());
if (Environment::VERSION_ID >= 31700) {
$expr->setAttribute('operator', 'binary_==');

$condition = new ConditionalTernary(
$expr,
$defaultNode,
Expand Down