Add information about type declarations to Class Constants #4545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aside from needing to fix the closing |
|
Sigh. I've pulled these changes locally and verified that they validate and build correctly. The error in GitHub actions is unrelated. I need to check whether I need to try to rerun GitHub actions at a later time, or if building locally is sufficient. |
| @@ -28,6 +28,12 @@ | |||
| Note that class constants are allocated once per class, and not for each | |||
| class instance. | |||
| </para> | |||
| <para> | |||
| As of PHP 8.3.0, class constants can have a scalar type such as <literal>bool</literal>, | |||
| <literal>int</literal>, <literal>float</literal>, <literal>string</literal>, or even | |||
There was a problem hiding this comment.
Nit: "or even" -> "and"
"and" is more muted in feeling, but I don't consider it an important enough change to block on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.3 introduced types to class constants, but the documentation doesn't seem to mention this yet. This PR updates the doc to mention it & provide an example.