-
Notifications
You must be signed in to change notification settings - Fork 809
Extract autoEncryption
driver options in MongoDB\Driver\Manager::__construct()
#4754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5ca64a5
to
dbba6f6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
dbba6f6
to
34e1c54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with extracting the table. I would suggest creating a separate table for autoEncryption options as opposed to adding them as rows to the driverOptions table.
34e1c54
to
dd2f36e
Compare
@@ -636,7 +636,7 @@ mongodb://[username:password@]host1[:port1][,host2[:port2],...[,hostN[:portN]]][ | |||
<entry> | |||
<para> | |||
Provides options to enable automatic client-side field level | |||
encryption. | |||
encryption. The list of options is described in the table below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to add a link to a reference in the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added - for reference, you can do this with <link linkend="anchor-name">Text</link>
Options supported by automatic encryption: | ||
<table> | ||
<title>autoEncryption</title> | ||
<tgroup cols="3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could add this to set the column widths, but this is not using %
anywhere.
<tgroup cols="3"> | |
<tgroup cols="3"> | |
<colspec colwidth="25%" colname="option"/> | |
<colspec colwidth="10%" colname="type"/> | |
<colspec colwidth="65%" colname="description"/> |
In few places it's using 2*
notation that is not handled by the website.
doc-en/reference/yaz/functions/yaz-hits.xml
Lines 61 to 63 in c21abf2
<tgroup cols="2"> | |
<colspec colwidth="1*" colname="element"/> | |
<colspec colwidth="2*" colname="description"/> |
The website CSS should use table-layout: auto
instead of fixed
so that the column width are adjusted automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we can change this here - we might have to talk to the website team for changes to this.
autoEncryption
driver options in MongoDB\Driver\Manager::__construct()
autoEncryption
driver options in MongoDB\Driver\Manager::__construct()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fix the
$driverOptions
parameter table this page to prevent unreadable nested array: https://www.php.net/manual/en/mongodb-driver-manager.construct.php#mongodb-driver-manager.construct-driveroptionsThis page is not modified: https://www.php.net/manual/en/mongodb-driver-manager.createclientencryption.php
Question: I would like to optimize the column width to give more space to the description.
https://jira.mongodb.org/browse/PHPC-2573