Fix GH-17687: initializer-string for array of ... warnings #18603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with gcc 15 the warning `-Wunterminated-string-initialization` is enabled by default. We make now use of the `nonstring` attribute to silence the warning for the cases where this is intended. This is targeted to 8.3 because of the people who compile with -Werror.
|
Introducing new attributes in a public header probably isn't a good idea. So I'll merge this into master and use local fixes on lower branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with gcc 15 the warning
-Wunterminated-string-initializationis enabled by default. We make now use of thenonstringattribute to silence the warning for the cases where this is intended. This is targeted to 8.3 because of the people who compile with -Werror.Upon merging up I'll handle ext/fileinfo too.
Lexbor should get fixed upstream.