ext/date: drop generic php_date_instantiate helper #18652
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielEScherzer
approved these changes
May 25, 2025
derickr
requested changes
May 26, 2025
There was a problem hiding this comment.
I don't mind changing php_date_instantiate to object_init_ex here logically, but removing the php_date_instantiate API is not OK.
And because of that, I would then also argue that all these instantiations should go through the same API call to stay consistent (in case php_date_instantiate() needs to do more than just object_init_ex.
I would therefore oppose this change altogether.
| object_init_ex(object, pce); | ||
| return object; | ||
| } /* }}} */ | ||
|
|
There was a problem hiding this comment.
You can't just remove an exported API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.