Move tests to their respective directories #19340
Open
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
tests-dir
branch
from
9b1340b to
8ae23fe
Compare
Girgias
reviewed
Aug 1, 2025
There was a problem hiding this comment.
This feels like it should be in ext/standard/tests/array/
Zend/tests/opcache/gh12366.inc
Outdated
There was a problem hiding this comment.
opcache stuff should probably be moved to ext/opcache?
Zend/tests/reflection/bug54013.phpt
Outdated
There was a problem hiding this comment.
Reflection stuff should probably be in ext/reflection
|
Yes, I wasn't sure if I should come up with multiple PRs or not. I'll create separate ones 👍 |
alexandre-daubois
force-pushed
the
tests-dir
branch
from
8ae23fe to
9a9d934
Compare
|
Updated to reach ~130 tests. Please tell me if you need me to reduce the PR even more 👍 |
Girgias
requested changes
Aug 14, 2025
There was a problem hiding this comment.
This should be a comparison tests not a string test
There was a problem hiding this comment.
This is not a string test but a ZPP test that should be in it's own directory if not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #19332 (comment), I propose to move tests not in a subdirs of
Zend/teststo their respective subdirectories. Tests for bugs and GitHub issues are also put in relevant subfolders.