fix build warnings for Haiku. #19575
Open
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
especially linker warning about php binary having an executable stack.
petk
reviewed
Aug 30, 2025
configure.ac
Outdated
| LDFLAGS="$LDFLAGS -Wl,-z,noexecstack" | ||
| ;; | ||
| esac | ||
|
|
There was a problem hiding this comment.
Yes, this works great. I've just tested it. It seems that Haiku handles PT_GNU_STACK differently to other Unix-like systems and it needs this linker flag. Probably something differently configured on it at the moment.
You can also move this few blocks to the top. Here:
diff --git a/configure.ac b/configure.ac
index 2bd6ae26ce6..dd5b9efb1c9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -207,6 +207,10 @@ AX_CHECK_COMPILE_FLAG([-fvisibility=hidden],
[CFLAGS="$CFLAGS -fvisibility=hidden"])
case $host_alias in
+dnl ...
+ *haiku*)
+ LDFLAGS="$LDFLAGS -Wl,-z,noexecstack"
+ ;;
*solaris*)
CPPFLAGS="$CPPFLAGS -D_POSIX_PTHREAD_SEMANTICS"
;;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
especially linker warning about php binary having an executable stack.