Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket #1157: support specific filenames as trigger for Shell. #1167

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

evs-xsarus
Copy link
Contributor

Q A
Branch feature/1157-triggered_by_filenames
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets comma-separated list of tickets fixed by the PR, if any

Question, I would like to be able to specify a pathname in the filename. This fails now because the pattern is checked against the filename without a path. How to fix?

New Task Checklist:

  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpunit tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

@evs-xsarus evs-xsarus force-pushed the feature/1157-triggered_by_filenames branch from 2a09e35 to f06e83b Compare February 28, 2025 14:03
@evs-xsarus evs-xsarus marked this pull request as ready for review February 28, 2025 14:10
Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A small copy/paste thing in the docs but good to go otherwise.


*Default: []*

This is a list of file patterns that will be ignored by the Symfony console task.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the shell task.

@evs-xsarus
Copy link
Contributor Author

@veewee the doc has been updated.

@veewee veewee added this to the 2.12.0 milestone Mar 11, 2025
@veewee veewee merged commit fed00cb into phpro:v2.x Mar 11, 2025
26 checks passed
@veewee
Copy link
Contributor

veewee commented Mar 11, 2025

Thanks!

@evs-xsarus evs-xsarus deleted the feature/1157-triggered_by_filenames branch March 11, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants