-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow prefix multiplexing behind reverse proxy #2319
Conversation
…#2319 for further details Signed-off-by: DL6ER <[email protected]>
…oard and API to be used behind a reverse proxy with path prefix multiplexing. Signed-off-by: DL6ER <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: DL6ER <[email protected]>
Conflicts have been resolved. |
Test failed. |
Looks like |
I think the problem is that the builds try to upload debug logs to docker-2 and the debug logs are massive and that causes |
No, they really fail. This PR added a new config option, but the the test were not adjusted.
|
As, yes, sorry. This frequently happens when we merge |
Signed-off-by: DL6ER <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: DL6ER <[email protected]>
Conflicts have been resolved. |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pihole-nginx-not-working/78511/3 |
What does this implement/fix?
Add new config option
webserver.paths.prefix
allowing Pi-hole's dashboard and API to be used behind a reverse proxy with path prefix multiplexing. This was already possible in Pi-hole v5.0 without having been added intentionally at any point. It is debatable whether this is a new feature or a bug (because it used to work like this pre-v6.0).A self-contained
docker-compose.yml
suitable for testing this can be found in #2298Note
You will need the related web branch
new/web_prefix
for this to work as expected.Related issue or feature (if applicable): Fixes #2298
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.