Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also set Expires= property for deleted cookies #2336

Merged
merged 1 commit into from
Mar 16, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 5, 2025

What does this implement/fix?

Also set Expires= property when the server tries to delete the SID cookie. RFC 6265, section 5.3 says:

The user agent MUST evict all expired cookies from the cookie store if, at any time, an expired cookie exists in the cookie store.


Related issue or feature (if applicable): Fixes #2322

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…okie. RFC 6265, section 5.3 says: The user agent MUST evict all expired cookies from the cookie store if, at any time, an expired cookie exists in the cookie store.

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER added the API label Mar 5, 2025
@DL6ER DL6ER requested a review from a team March 5, 2025 16:19
@DL6ER DL6ER changed the title Also set Expires= property for deleted cookies Mar 5, 2025
@DL6ER DL6ER merged commit 3460b90 into development Mar 16, 2025
18 checks passed
@DL6ER DL6ER deleted the tweak/session_expiry branch March 16, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants