Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration test update for Esmerald #1087

Merged
merged 3 commits into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions piccolo/apps/asgi/commands/new.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
SERVERS = ["uvicorn", "Hypercorn", "granian"]
ROUTER_DEPENDENCIES = {
"starlette": ["starlette"],
"fastapi": ["fastapi>=0.112.1"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we version pinned this because of a version mismatch with Starlette - presumably this is fixed now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it's fixed and I had no problems in testing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks

"fastapi": ["fastapi"],
"blacksheep": ["blacksheep"],
"litestar": ["litestar"],
"esmerald": ["esmerald==3.3.0"],
"esmerald": ["esmerald"],
"lilya": ["lilya"],
}
ROUTERS = list(ROUTER_DEPENDENCIES.keys())
Expand Down
1 change: 1 addition & 0 deletions requirements/test-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
coveralls==3.3.1
httpx==0.27.2
pytest-cov==3.0.0
pytest==6.2.5
python-dateutil==2.8.2
Expand Down
38 changes: 10 additions & 28 deletions tests/apps/asgi/commands/files/dummy_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
import sys
import typing as t

from httpx import AsyncClient

def dummy_server(app: t.Union[str, t.Callable] = "app:app"):

async def dummy_server(app: t.Union[str, t.Callable] = "app:app"):
"""
A very simplistic ASGI server. It's used to run the generated ASGI
applications in unit tests.
Expand All @@ -20,33 +22,13 @@ def dummy_server(app: t.Union[str, t.Callable] = "app:app"):
if isinstance(app, str):
path, app_name = app.rsplit(":")
module = importlib.import_module(path)
app = getattr(module, app_name)

async def send(message):
if message["type"] == "http.response.start":
if message["status"] == 200:
print("Received 200")
else:
sys.exit("200 not received from app")

async def receive():
pass

scope = {
"scheme": "http",
"type": "http",
"path": "/",
"raw_path": b"/",
"method": "GET",
"query_string": b"",
"headers": [],
}
if callable(app):
asyncio.run(app(scope, receive, send))
print("Exiting dummy server ...")
else:
sys.exit("The app isn't callable!")
app = t.cast(t.Callable, getattr(module, app_name))

async with AsyncClient(app=app) as client:
response = await client.get("http://localhost:8000")
if response.status_code != 200:
sys.exit("The app isn't callable!")


if __name__ == "__main__":
dummy_server()
asyncio.run(dummy_server())
Loading