fix: parse on selected grammar change

picomet · Sep 8, 2024 · c666373 · c666373
1 parent 4eed932
commit c666373
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/nervous-gifts-dance.md b/.changeset/nervous-gifts-dance.md
@@ -0,0 +1,5 @@
+---
+"treeground": patch
+---
+
+fix: parse on selected grammar change
diff --git a/src/components/Editor.tsx b/src/components/Editor.tsx
@@ -27,7 +27,6 @@ const Editor: Component<Props> = (props) => {
       if (editor) {
         editor.dispose();
       }
-      props.setEditor(null);
     });
     if (selectedGrammar) {
       createHighlighter({
@@ -64,6 +63,8 @@ const Editor: Component<Props> = (props) => {
         });
         props.setEditor(editor);
       });
+    } else {
+      props.setEditor(null);
     }
   });
 

diff --git a/src/components/Nav.tsx b/src/components/Nav.tsx
@@ -81,6 +81,7 @@ const Nav: Component<{
   const handleGrammarChange = (e: Event & { target: HTMLSelectElement }) => {
     const value = e.target.value;
     if (value) {
+      props.parseOnNewEditor();
       batch(() => {
         props.setSelectedGrammar(value);
         props.setSelectedHighlighter(

diff --git a/src/components/TreeGround.tsx b/src/components/TreeGround.tsx
@@ -125,7 +125,6 @@ function App() {
 
   createEffect(() => {
     localStorage.setItem("treeground.selectedGrammar", selectedGrammar() || "");
-    parseOnNewEditor();
   });
 
   createEffect(() => {