Add timeout to acquireAndWait() method #3
Conversation
Added support for millisecond timeout in acquireAndWait while preserving compatibility with 0-argument version of function. Includes support for twos-compliment counter-wrap. (only supports one counter wrap, but since timeout is limited to uint32_t, specifying enough time to make more than one counter wrap is impossible anyway. Since a millis() counter wrap in uint32_t is about 12 1/2 years, this should be adequate.
Add timeout to acquireAndWait() method
|
Awesome… Thanks!! Owen
|
|
question, is it possible to publish this change in Particle's Build/library? |
|
Hi, I wanted to test it but have not had the chance. Have you tested the On Mon, Feb 15, 2016 at 5:53 AM, Gustavo [email protected] wrote:
|
|
alright, I'll give it a try and post back. |
|
Hi Scott, |
|
Thanks Gustavo, Good suggestion, I can make the changes. I'm not able to Scott On Mon, Feb 22, 2016 at 5:18 AM, Gustavo [email protected] wrote:
|
The proposed changes implement a timeout argument to acquireAndWait() in a manner compatible with existing behavior of the library. If timeout=0 or no timeout is specified, default is to wait until acquisition finishes even if it never does.
If timeout is given a non-zero value, then the function will return when acquisition finishes or after timeout milliseconds, whichever occurs first. The timeout function is written in such a way that it should handle millis() counter wraps.
I've done basic testing of this code in my application and it appears to work.