Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brokercheck an all backends #393

Closed
wants to merge 1 commit into from
Closed

Brokercheck an all backends #393

wants to merge 1 commit into from

Conversation

guilledk
Copy link
Contributor

Begin work on #387

Do a brokercheck without logging on all backends, we pull backends from piker.brokers.__brokers__, I added deribit while I was at it cause I forgot to when doing the backend PR.

Currently not passing cause binance doesn't have a trades_dialogue, or get_balance.

Also should we log to console more like when running brokercheck on cli? This would require log_cli flag to be set on pytest config.

…heck argument to get_client in binance, kraken and questrade
@goodboy
Copy link
Contributor

goodboy commented Aug 27, 2022

Currently not passing cause binance doesn't have a trades_dialogue, or get_balance.

Can we just maybe have a parameterization based on some kind of "supported" features log? I'm thinking we could check the backend subpackage module for an table that maybe denotes which features are supported and then we map those flags to a method set?

Also should we log to console more like when running brokercheck on cli? This would require log_cli flag to be set on pytest config.

Don't see why not, you can set it in the test module or a pytest.ini iirc.

@goodboy goodboy mentioned this pull request May 23, 2023
51 tasks
@goodboy
Copy link
Contributor

goodboy commented May 25, 2023

Replaced by warnings added in #489

@goodboy goodboy closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants