refactor: replace setHeaders function with optimized inline header setting #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phillip9587
force-pushed
the
refactor-set-headers
branch
from
f9a78ce
to
733b318
Compare
wesleytodd
requested changes
Nov 26, 2024
| @@ -288,7 +288,9 @@ function send (req, res, status, headers, message) { | |||
| res.removeHeader('Content-Range') | |||
|
|
|||
| // response headers | |||
| setHeaders(res, headers) | |||
| for (const [key, value] of Object.entries(headers ?? {})) { | |||
There was a problem hiding this comment.
We probably want to do some bench-marking on this. I don't want to armchair micro-benchmark on this, but I am pretty sure that this is making a unnecessary array per header and may be slower than the array from. Either way, these are the kind of changes that I want us to have a easy and reliable way to truly test the perf of before landing..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the
setHeadersfunction with a loop that sets headers directly usingObject.entries. This change eliminates the need for the separatesetHeadersfunction.