fix replacement metrics

pimlicolabs · Feb 4, 2025 · 4df2ea3 · 4df2ea3
1 parent 21f837c
commit 4df2ea3
Showing 1 changed file with 15 additions and 10 deletions.
diff --git a/src/executor/executorManager.ts b/src/executor/executorManager.ts
@@ -753,16 +753,6 @@ export class ExecutorManager {
             this.senderManager.markWalletProcessed(txInfo.executor)
         }
 
-        // Log metrics.
-        const replaceStatus =
-            bundleResult && bundleResult.status === "bundle_success"
-                ? "succeeded"
-                : "failed"
-
-        this.metrics.replacedTransactions
-            .labels({ reason, status: replaceStatus })
-            .inc()
-
         // Check if the transaction is potentially included.
         const nonceTooLow =
             bundleResult.status === "bundle_submission_failure" &&
@@ -778,6 +768,21 @@ export class ExecutorManager {
 
         const potentiallyIncluded = nonceTooLow || allOpsFailedSimulation
 
+        // log metrics
+        const replaceStatus = (() => {
+            switch (true) {
+                case potentiallyIncluded:
+                    return "potentially_already_included"
+                case bundleResult?.status === "bundle_success":
+                    return "replaced"
+                default:
+                    return "failed"
+            }
+        })()
+        this.metrics.replacedTransactions
+            .labels({ reason, status: replaceStatus })
+            .inc()
+
         if (potentiallyIncluded) {
             this.logger.info(
                 { oldTxHash },