Cleanup executors #416
Merged
Cleanup executors #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mouseless0x
force-pushed
the
cleanup-executors
branch
from
25fbc5e to
a2cee31
Compare
src/executor/executor.ts
Outdated
| @@ -677,144 +284,79 @@ export class Executor { | |||
| }) | |||
|
|
|||
| let childLogger = this.logger.child({ | |||
| userOperations: opsWithHashes.map((oh) => oh.userOperationHash), | |||
| userOperations: userOperations.map((op) => op.hash), | |||
There was a problem hiding this comment.
I actually liked opsWithHashes since I don't expect the userOperations to have an hash.
There was a problem hiding this comment.
that makes sense, theUserOperationInfo type now has a seperate field for userOp/userOpHash
pavlovdog
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.