Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cache #20

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
8d43411
base navigation
LucasPrioste92 Apr 5, 2024
673aeb2
Merge branch 'feature/splash-screen' into feature/navigation
LucasPrioste92 Apr 5, 2024
907f2ce
update colors background and add scaffold to support bottom bar
LucasPrioste92 Apr 8, 2024
14c67a3
bottom bar
LucasPrioste92 Apr 8, 2024
388f4f2
route with arg symbolId on Detail screen
LucasPrioste92 Apr 8, 2024
398453d
initial setup alpaca API
LucasPrioste92 Apr 8, 2024
3f5ed1f
update dimensions
LucasPrioste92 Apr 8, 2024
51bce36
Merge branch 'feature/navigation' into feature/alpaca-api
LucasPrioste92 Apr 8, 2024
31d797e
update alpaca news service
LucasPrioste92 Apr 10, 2024
739ee01
- refactor alpaca news ws service
LucasPrioste92 Apr 11, 2024
201b4b2
- alpaca news API
LucasPrioste92 Apr 11, 2024
b539b0c
- alpaca news API
LucasPrioste92 Apr 11, 2024
2798774
- setup Unit Test libs
LucasPrioste92 Apr 11, 2024
d26ca4f
- faker dependency
LucasPrioste92 Apr 12, 2024
2b44d41
- unit test (NewsRepository)
LucasPrioste92 Apr 12, 2024
734e555
- unit test (ChangeFilterNews UseCase)
LucasPrioste92 Apr 12, 2024
e487af3
- main carousel news
LucasPrioste92 Apr 17, 2024
84360dd
- main carousel news add anim
LucasPrioste92 Apr 18, 2024
aac9174
- show all news
LucasPrioste92 Apr 19, 2024
0b8c085
- real time news
LucasPrioste92 Apr 22, 2024
80c43b2
- pagination news
LucasPrioste92 Apr 22, 2024
dd409ca
- date picker ui
LucasPrioste92 Apr 24, 2024
3f639fa
- logic to apply filters on VM
LucasPrioste92 Apr 26, 2024
9a765df
- unit test
LucasPrioste92 Apr 29, 2024
fa5c993
- update libs
LucasPrioste92 Apr 29, 2024
232d958
- update symbol crypto
LucasPrioste92 Apr 29, 2024
660586c
- assets API
LucasPrioste92 May 2, 2024
9d0225c
- refactor alpaca data API
LucasPrioste92 May 2, 2024
92f6b79
- trades, quotes, bars info
LucasPrioste92 May 2, 2024
faaf727
- use case to get realtime tardes, quotes and bar
LucasPrioste92 May 6, 2024
0616d85
- unit test MarketRemoteDataSource and AssetRemoteDataSource
LucasPrioste92 May 6, 2024
b6235b6
- unit test AssetsRepository
LucasPrioste92 May 6, 2024
107ed0d
- search input assets
LucasPrioste92 May 8, 2024
5f26ec9
- handle error assets list
LucasPrioste92 May 13, 2024
cda4490
- ui test HomeViewModel
LucasPrioste92 May 13, 2024
378bf20
- header detail screen
LucasPrioste92 May 13, 2024
972655e
- base chart
LucasPrioste92 May 15, 2024
c12e93a
- new version chart
LucasPrioste92 May 20, 2024
40285a7
- update chart
LucasPrioste92 May 21, 2024
9c475d8
- update chart
LucasPrioste92 May 23, 2024
14785b8
- get real time quotes
LucasPrioste92 May 24, 2024
2b2ab02
- get trades
LucasPrioste92 May 28, 2024
2312385
- enabled pull to refresh
LucasPrioste92 May 28, 2024
68d5979
- chart just consume horizontal dragging
LucasPrioste92 May 28, 2024
5253271
- unit test DetailViewModel
LucasPrioste92 May 29, 2024
a85b968
setup room db
LucasPrioste92 May 31, 2024
978cf5c
cache all assets
LucasPrioste92 Jun 4, 2024
90efc9b
cache news and logic to clean cache and retrieve news when the app is…
LucasPrioste92 Jun 12, 2024
cb01fec
update popBackStack to navigateUp
LucasPrioste92 Jun 12, 2024
d2e4719
fix bug when user is offline and data is not being loaded from cache
LucasPrioste92 Jun 12, 2024
c593db9
unit test Assets Cached
LucasPrioste92 Jun 12, 2024
88df26d
unit test News Cached
LucasPrioste92 Jun 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update dimensions
LucasPrioste92 committed Apr 8, 2024
commit 3f5ed1fad6e020b6b17b58e4b76e41e5fa4c7122
Original file line number Diff line number Diff line change
@@ -26,10 +26,10 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.dp
import androidx.navigation.NavHostController
import androidx.navigation.compose.currentBackStackEntryAsState
import dev.pinkroom.marketsight.R
import dev.pinkroom.marketsight.ui.core.theme.dimens

@Composable
fun NavigationBottomBar(
@@ -60,11 +60,11 @@ fun NavigationBottomBar(
Card(
modifier = Modifier
.fillMaxWidth()
.padding(horizontal = 25.dp)
.padding(bottom = 15.dp),
shape = RoundedCornerShape(10.dp),
.padding(horizontal = dimens.horizontalPadding)
.padding(bottom = dimens.menuBottomPadding),
shape = RoundedCornerShape(dimens.smallShape),
elevation = CardDefaults.cardElevation(
defaultElevation = 2.dp
defaultElevation = dimens.lowElevation,
),
) {
NavigationBar(
@@ -101,7 +101,7 @@ fun RowScope.AddItem(
val icon = if (isThisItemTheCurrentRoute) item.selectedIcon
else item.unselectedIcon
val sizeIcon = animateDpAsState(
targetValue = if (isThisItemTheCurrentRoute) 38.dp else 24.dp,
targetValue = if (isThisItemTheCurrentRoute) dimens.largeIconSize else dimens.normalIconSize,
animationSpec = tween(
durationMillis = 200,
),
Original file line number Diff line number Diff line change
@@ -31,6 +31,26 @@ class Dimensions(
val normalPadding: Dp = 16.dp,
val largePadding: Dp = 24.dp,
val xLargePadding: Dp = 32.dp,

// Icon
val normalIconSize: Dp = 24.dp,
val largeIconSize: Dp = 38.dp,

// Elevation
val lowElevation: Dp = 2.dp,
val normalElevation: Dp = 5.dp,
val largeElevation: Dp = 8.dp,

// Shape
val smallShape: Dp = 10.dp,
val normalShape: Dp = 15.dp,
val largeShape: Dp = 22.dp,

// Page Padding
val horizontalPadding: Dp = 25.dp,

// Others
val menuBottomPadding: Dp = 15.dp,
)

val dimens: Dimensions