Internal: Revert "Internal: Fix error in React 19 with fetchpriority (#…

…3976)" (#3982)
pinterest · Feb 6, 2025 · 71d555a · 71d555a
1 parent 760c925
commit 71d555a
Show file tree

Hide file tree

Showing 11 changed files with 24 additions and 48 deletions.
diff --git a/packages/gestalt/src/Avatar.jsdom.test.tsx b/packages/gestalt/src/Avatar.jsdom.test.tsx
@@ -2,13 +2,7 @@ import { fireEvent, render, screen } from '@testing-library/react';
 import Avatar from './Avatar';
 
 test('Avatar handles Image error by rendering the default avatar', () => {
-  const error = jest.spyOn(console, 'error').mockImplementation(() => {});
   render(<Avatar name="Name" src="example.com" />);
-  // This error is expected because of a change in React 19 that now only accepts fetchPriority in camel case while in react 18 it only accepts it in lowercase
-  expect(error.mock.calls[0]![0]).toEqual(
-    expect.stringContaining('Warning: React does not recognize the `%s` prop on a DOM element'),
-  );
-  expect(error.mock.calls[0]![1]).toEqual(expect.stringContaining('fetchPriority'));
   fireEvent.error(screen.getByAltText('Name'));
 
   expect(screen.getByText('N')).toBeTruthy();

diff --git a/packages/gestalt/src/AvatarGroup.jsdom.test.tsx b/packages/gestalt/src/AvatarGroup.jsdom.test.tsx
@@ -54,7 +54,6 @@ describe('AvatarGroup', () => {
     );
 
   it('renders xs display-only AvatarGroup with image', () => {
-    const error = jest.spyOn(console, 'error').mockImplementation(() => {});
     const { baseElement } = renderCmp({
       collaborators: [
         {
@@ -64,11 +63,6 @@ describe('AvatarGroup', () => {
       ],
       size: 'xs',
     });
-    // This error is expected because of a change in React 19 that now only accepts fetchPriority in camel case while in react 18 it only accepts it in lowercase
-    expect(error.mock.calls[0]![0]).toEqual(
-      expect.stringContaining('Warning: React does not recognize the `%s` prop on a DOM element'),
-    );
-    expect(error.mock.calls[0]![1]).toEqual(expect.stringContaining('fetchPriority'));
     expect(baseElement).toMatchSnapshot();
   });
 

diff --git a/packages/gestalt/src/DropdownItem.jsdom.test.tsx b/packages/gestalt/src/DropdownItem.jsdom.test.tsx
@@ -42,7 +42,6 @@ describe('Dropdown.Item', () => {
   });
 
   test('adds avatar', () => {
-    const error = jest.spyOn(console, 'error').mockImplementation(() => {});
     render(
       <Dropdown.Item
         avatar={{
@@ -56,11 +55,6 @@ describe('Dropdown.Item', () => {
         option={{ value: 'item 4', label: 'Item 4' }}
       />,
     );
-    // This error is expected because of a change in React 19 that now only accepts fetchPriority in camel case while in react 18 it only accepts it in lowercase
-    expect(error.mock.calls[0]![0]).toEqual(
-      expect.stringContaining('Warning: React does not recognize the `%s` prop on a DOM element'),
-    );
-    expect(error.mock.calls[0]![1]).toEqual(expect.stringContaining('fetchPriority'));
     expect(screen.getByAltText('Ayesha avatar')).toBeInTheDocument();
   });
 

diff --git a/packages/gestalt/src/DropdownLink.jsdom.test.tsx b/packages/gestalt/src/DropdownLink.jsdom.test.tsx
@@ -64,7 +64,6 @@ describe('Dropdown.Link', () => {
   });
 
   test('adds avatar', () => {
-    const error = jest.spyOn(console, 'error').mockImplementation(() => {});
     render(
       <Dropdown.Link
         avatar={{
@@ -79,11 +78,6 @@ describe('Dropdown.Link', () => {
         option={{ value: 'item 4', label: 'Item 4' }}
       />,
     );
-    // This error is expected because of a change in React 19 that now only accepts fetchPriority in camel case while in react 18 it only accepts it in lowercase
-    expect(error.mock.calls[0]![0]).toEqual(
-      expect.stringContaining('Warning: React does not recognize the `%s` prop on a DOM element'),
-    );
-    expect(error.mock.calls[0]![1]).toEqual(expect.stringContaining('fetchPriority'));
     expect(screen.getByAltText('Ayesha avatar')).toBeInTheDocument();
   });
 });
diff --git a/packages/gestalt/src/Image.tsx b/packages/gestalt/src/Image.tsx
@@ -219,7 +219,7 @@ export default class Image extends PureComponent<Props> {
           className={imageStyles}
           crossOrigin={crossOrigin}
           decoding={decoding}
-          fetchPriority={fetchPriority}
+          fetchpriority={fetchPriority}
           // @ts-expect-error - TS2322 - Type '"auto" | "lazy" | "eager" | undefined' is not assignable to type '"lazy" | "eager" | undefined'.
           loading={loading}
           onError={this.handleError}

diff --git a/packages/gestalt/src/__snapshots__/Avatar.test.tsx.snap b/packages/gestalt/src/__snapshots__/Avatar.test.tsx.snap
@@ -134,7 +134,7 @@ exports[`Avatar renders the checkmark on verified default 1`] = `
         <img
           alt="Strava"
           className="img"
-          fetchPriority="auto"
+          fetchpriority="auto"
           loading="auto"
           onError={[Function]}
           onLoad={[Function]}
@@ -221,7 +221,7 @@ exports[`Avatar renders the correct size - lg 1`] = `
         <img
           alt="Strava"
           className="img"
-          fetchPriority="auto"
+          fetchpriority="auto"
           loading="auto"
           onError={[Function]}
           onLoad={[Function]}
@@ -271,7 +271,7 @@ exports[`Avatar renders the correct size - md 1`] = `
         <img
           alt="Strava"
           className="img"
-          fetchPriority="auto"
+          fetchpriority="auto"
           loading="auto"
           onError={[Function]}
           onLoad={[Function]}
@@ -321,7 +321,7 @@ exports[`Avatar renders the correct size - sm 1`] = `
         <img
           alt="Strava"
           className="img"
-          fetchPriority="auto"
+          fetchpriority="auto"
           loading="auto"
           onError={[Function]}
           onLoad={[Function]}
@@ -371,7 +371,7 @@ exports[`Avatar renders the correct size - xl 1`] = `
         <img
           alt="Strava"
           className="img"
-          fetchPriority="auto"
+          fetchpriority="auto"
           loading="auto"
           onError={[Function]}
           onLoad={[Function]}
@@ -421,7 +421,7 @@ exports[`Avatar renders the correct size - xs 1`] = `
         <img
           alt="Strava"
           className="img"
-          fetchPriority="auto"
+          fetchpriority="auto"
           loading="auto"
           onError={[Function]}
           onLoad={[Function]}
@@ -471,7 +471,7 @@ exports[`Avatar renders the correct src 1`] = `
         <img
           alt="Strava"
           className="img"
-          fetchPriority="auto"
+          fetchpriority="auto"
           loading="auto"
           onError={[Function]}
           onLoad={[Function]}

diff --git a/packages/gestalt/src/__snapshots__/BannerOverlay.test.tsx.snap b/packages/gestalt/src/__snapshots__/BannerOverlay.test.tsx.snap
@@ -55,7 +55,7 @@ Array [
                     <img
                       alt=""
                       className="img"
-                      fetchPriority="auto"
+                      fetchpriority="auto"
                       loading="auto"
                       onError={[Function]}
                       onLoad={[Function]}
@@ -170,7 +170,7 @@ Array [
                 <img
                   alt=""
                   className="img"
-                  fetchPriority="auto"
+                  fetchpriority="auto"
                   loading="auto"
                   onError={[Function]}
                   onLoad={[Function]}
@@ -295,7 +295,7 @@ Array [
                     <img
                       alt=""
                       className="img"
-                      fetchPriority="auto"
+                      fetchpriority="auto"
                       loading="auto"
                       onError={[Function]}
                       onLoad={[Function]}
@@ -410,7 +410,7 @@ Array [
                 <img
                   alt=""
                   className="img"
-                  fetchPriority="auto"
+                  fetchpriority="auto"
                   loading="auto"
                   onError={[Function]}
                   onLoad={[Function]}

diff --git a/packages/gestalt/src/__snapshots__/Checkbox.test.tsx.snap b/packages/gestalt/src/__snapshots__/Checkbox.test.tsx.snap
@@ -450,7 +450,7 @@ exports[`Checkbox with an image 1`] = `
           <img
             alt=""
             className="img"
-            fetchPriority="auto"
+            fetchpriority="auto"
             loading="auto"
             onError={[Function]}
             onLoad={[Function]}

diff --git a/packages/gestalt/src/__snapshots__/Image.test.tsx.snap b/packages/gestalt/src/__snapshots__/Image.test.tsx.snap
@@ -13,7 +13,7 @@ exports[`Image matches snapshot 1`] = `
   <img
     alt="foo"
     className="img"
-    fetchPriority="auto"
+    fetchpriority="auto"
     loading="auto"
     onError={[Function]}
     onLoad={[Function]}
@@ -36,7 +36,7 @@ exports[`Image with crossorigin specified matches snapshot 1`] = `
     alt="foo"
     className="img"
     crossOrigin="anonymous"
-    fetchPriority="auto"
+    fetchpriority="auto"
     loading="auto"
     onError={[Function]}
     onLoad={[Function]}
@@ -59,7 +59,7 @@ exports[`Image with decoding specified matches snapshot 1`] = `
     alt="foo"
     className="img"
     decoding="sync"
-    fetchPriority="auto"
+    fetchpriority="auto"
     loading="auto"
     onError={[Function]}
     onLoad={[Function]}
@@ -81,7 +81,7 @@ exports[`Image with fetchPriority specified matches snapshot 1`] = `
   <img
     alt="foo"
     className="img"
-    fetchPriority="high"
+    fetchpriority="high"
     loading="auto"
     onError={[Function]}
     onLoad={[Function]}
@@ -104,7 +104,7 @@ exports[`Image with fit: contain and role matches snapshot 1`] = `
   <img
     alt="foo"
     className="img scaledImg"
-    fetchPriority="auto"
+    fetchpriority="auto"
     loading="auto"
     onError={[Function]}
     onLoad={[Function]}
@@ -138,7 +138,7 @@ exports[`Image with fit: contain matches snapshot 1`] = `
   <img
     alt="foo"
     className="img scaledImg"
-    fetchPriority="auto"
+    fetchpriority="auto"
     loading="auto"
     onError={[Function]}
     onLoad={[Function]}
@@ -171,7 +171,7 @@ exports[`Image with fit: cover matches snapshot 1`] = `
   <img
     alt="foo"
     className="img scaledImg"
-    fetchPriority="auto"
+    fetchpriority="auto"
     loading="auto"
     onError={[Function]}
     onLoad={[Function]}
@@ -203,7 +203,7 @@ exports[`Image with overlay matches snapshot 1`] = `
   <img
     alt="foo"
     className="img"
-    fetchPriority="auto"
+    fetchpriority="auto"
     loading="auto"
     onError={[Function]}
     onLoad={[Function]}

diff --git a/packages/gestalt/src/__snapshots__/RadioButton.test.tsx.snap b/packages/gestalt/src/__snapshots__/RadioButton.test.tsx.snap
@@ -308,7 +308,7 @@ exports[`RadioButton with image 1`] = `
         <img
           alt=""
           className="img"
-          fetchPriority="auto"
+          fetchpriority="auto"
           loading="auto"
           onError={[Function]}
           onLoad={[Function]}

diff --git a/packages/gestalt/src/__snapshots__/Toast.test.tsx.snap b/packages/gestalt/src/__snapshots__/Toast.test.tsx.snap
@@ -188,7 +188,7 @@ exports[`<Toast /> Text + Image + Button 1`] = `
               <img
                 alt=""
                 className="img"
-                fetchPriority="auto"
+                fetchpriority="auto"
                 loading="auto"
                 onError={[Function]}
                 onLoad={[Function]}
@@ -312,7 +312,7 @@ exports[`<Toast /> Text + Image 1`] = `
               <img
                 alt=""
                 className="img"
-                fetchPriority="auto"
+                fetchpriority="auto"
                 loading="auto"
                 onError={[Function]}
                 onLoad={[Function]}