Spinner: VR implementation changes #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gestalt ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Is it meant to be transparent ? |
|
There no dark mode version? |
AlbertCarreras
approved these changes
Sep 23, 2024
yes, it is. |
AFAIK, no |
diyorbek
force-pushed
the
vr-spinner
branch
from
b7483d0 to
b69fd4c
Compare
AlbertCarreras
approved these changes
Sep 27, 2024
packages/gestalt-design-tokens/tokens/vr-theme/comp/spinner.json
Outdated
Show resolved
Hide resolved
rlingineni
reviewed
Sep 27, 2024
| @@ -436,6 +436,19 @@ | |||
| } | |||
| } | |||
| }, | |||
| "spinner": { | |||
There was a problem hiding this comment.
you can remove these ones
| @@ -259,6 +259,19 @@ | |||
| } | |||
| } | |||
| }, | |||
| "spinner": { | |||
There was a problem hiding this comment.
you dont need this either
There was a problem hiding this comment.
+1 - the VR tokens will be pulled in here
AlbertCarreras
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
LGTM just use directly the VR theme tokens if @rlingineni is okey with Schema naming
rlingineni
approved these changes
Sep 30, 2024
| @@ -259,6 +259,19 @@ | |||
| } | |||
| } | |||
| }, | |||
| "spinner": { | |||
There was a problem hiding this comment.
+1 - the VR tokens will be pulled in here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Links
Checklist