Tokens: Refactor Token Build Script #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component token test
✅ Deploy Preview for gestalt ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const { getIOSConfiguration } = require('./platforms/ios'); | ||
| const { registerWebFormats } = require('./formatters/registerWebFormats'); | ||
|
|
||
| StyleDictionary.registerFileHeader({ |
There was a problem hiding this comment.
shoudl we move this out too to keep everything isolated?
AlbertCarreras
approved these changes
Sep 30, 2024
✅ Deploy Preview for gestalt ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Remove component token changes
rlingineni
force-pushed
the
ravi-refactor-tokenscript
branch
from
99e1397 to
852152f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Instructions
This is a refactor of our
build.jstoken script which was previously hard to maintain and read.Everything now lives under the
design-tokens/srcdirectory.