Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix Tokens Page not loading #3792

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

rlingineni
Copy link
Contributor

@rlingineni rlingineni commented Oct 2, 2024

Pull Request Instructions

Fix design tokens overview page not loading on direct link.

This moves the loading of data to be Server Side instead of a client-side import.

Links

  • Jira
  • [TDD](link to Paper doc)
  • [Figma](link to Figma file)

Checklist

  • Added unit tests
  • Added documentation + accessibility tests
  • Verified accessibility: keyboard & screen reader interaction
  • Checked dark mode, responsiveness, and right-to-left support
  • Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

@rlingineni rlingineni requested a review from a team as a code owner October 2, 2024 21:42
@rlingineni rlingineni added the patch release Patch release label Oct 2, 2024
@rlingineni rlingineni changed the title Ravi token import Docs: Fix Page not loading Oct 2, 2024
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit 68f44b7
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/66fdbd648e073d00083a99b2
😎 Deploy Preview https://deploy-preview-3792--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rlingineni rlingineni changed the title Docs: Fix Page not loading Docs: Fix Tokens Page not loading Oct 2, 2024
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit cb0148d
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/66fdbfe12a97c000082b6e2f
😎 Deploy Preview https://deploy-preview-3792--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlbertCarreras AlbertCarreras merged commit 4d34e97 into pinterest:master Oct 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants