Tokens: Add XFN Component Tokens #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component token test
Remove component token changes
✅ Deploy Preview for gestalt ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rlingineni
added
patch release
AlbertCarreras
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a working system for component tokens.
Adding new component tokens to the
compfolder will automatically be picked up by the build system and outputted to the relevant platform outputs.This is the hierarchy for component token overrides.
What changed?
StyleDictionary provides two classes of inputs for tokens:
sourcesandincludes.This PR migrates all existing sources to the
includesproperty, and then an override occurs with the corresponding platform file withweb, mobile or ios.jsonAt a high level, what changes does this PR introduce?
Why?
We needed a better system for rollout component token updates. We also anticipate that component tokens will be duplicated and different across platforms in terms of their values. Hence we needed a better system to support overrides.
Links
Checklist