Masonry: Update fluid grid to not floor column width (take two) #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gestalt ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
manvoid
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR re-lands the change originally introduced in #3874 (which updates
fullWidthLayoutcolumn widths to not be floored) and addresses the bug that caused it to be reverted.Why was this reverted previously
This previous change was reverted after it was reported that pins were "stacking" . After doing some debugging, I was able to trace the issue down to the
initializeHeightsArrayfunction, which is called during multi-column layout. Currently, it has some logic to determinecolumnbased on a combination ofposition.left+columnWidthAndGutter- when column widths are floating point numbers, this ends up breaking since the calculatedcolumnis no longer an integer.This PR fixes the above issue by ensuring that the above calculation is rounded to the nearest integer.
Test Plan
Patched this locally and testing in pinboard
Before
After