Clean up ServerlessClient #1778
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osoriano
force-pushed
the
osoriano/cleanup-mock-tt-server
branch
2 times, most recently
from
e9ab473 to
321b6c0
Compare
osoriano
force-pushed
the
osoriano/cleanup-mock-tt-server
branch
from
321b6c0 to
72eb2de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The mock
ServerlessClientwas added long ago. Instead of maintaining theServerlessClient(e.g. a mock server), the Teletraan API can be set up for local development now.Remove the
ServerlessClientmock server and the related code in favor of the new approachTesting
Tested with a local Teletraan API service and ensured the deployment completed successfully