Fix to pass tests

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
pipe-cd · Dec 27, 2024 · 2e7b2f5 · 2e7b2f5
1 parent bcfd121
commit 2e7b2f5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/pkg/app/pipedv1/plugin/kubernetes/provider/resource.go b/pkg/app/pipedv1/plugin/kubernetes/provider/resource.go
@@ -121,9 +121,8 @@ func FindRemoveResources(manifests, namespacedLiveResources, clusterScopedLiveRe
 		}
 		for _, r := range clusterScopedLiveResources {
 			// We don't care about the namespace of the cluster-scoped resources.
-			k := r.Key().normalize().withoutNamespace()
-			if _, ok := normalizedKeys[k]; !ok {
-				removeKeys = append(removeKeys, k)
+			if _, ok := normalizedKeys[r.Key().normalize().withoutNamespace()]; !ok {
+				removeKeys = append(removeKeys, r.Key())
 			}
 		}
 	}

diff --git a/pkg/app/pipedv1/plugin/kubernetes/provider/resource_test.go b/pkg/app/pipedv1/plugin/kubernetes/provider/resource_test.go
@@ -125,12 +125,12 @@ metadata:
 `,
 			expectedRemoveKeys: []ResourceKey{
 				{
-					groupKind: schema.GroupKind{Group: "", Kind: "secret"},
+					groupKind: schema.GroupKind{Group: "", Kind: "Secret"},
 					namespace: "default",
 					name:      "old-secret",
 				},
 				{
-					groupKind: schema.GroupKind{Group: "", Kind: "namespace"},
+					groupKind: schema.GroupKind{Group: "", Kind: "Namespace"},
 					namespace: "",
 					name:      "test-namespace",
 				},