Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix the status of Plan Preview for ECS #4817

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Mar 12, 2024

What this PR does / why we need it:

Plan Preview is not supported yet for ECS.

@t-kikuc t-kikuc changed the title Doc feature status plan ecs [doc] Fix the status of Plan Preview for ECS Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.94%. Comparing base (5efd4cd) to head (bb5bba9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4817   +/-   ##
=======================================
  Coverage   28.94%   28.94%           
=======================================
  Files         317      317           
  Lines       40333    40333           
=======================================
  Hits        11674    11674           
  Misses      27731    27731           
  Partials      928      928           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc t-kikuc enabled auto-merge (squash) March 12, 2024 01:32
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@t-kikuc t-kikuc merged commit d26ca6f into master Mar 12, 2024
14 checks passed
@t-kikuc t-kikuc deleted the doc-feature-status-plan-ecs branch March 12, 2024 02:11
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
@t-kikuc t-kikuc mentioned this pull request Apr 9, 2024
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Apr 18, 2024
* Fix status of PlanPreview for ECS: dev and latest

Signed-off-by: t-kikuc <[email protected]>

* Fix status of PlanPreview for ECS: older versions

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants