Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install tzdata to piped-base image #5439

Closed
wants to merge 2 commits into from
Closed

Conversation

khanhtc1202
Copy link
Member

What this PR does:

as title

Why we need it:

Users want to use tzdata package to set timezone while using script in SCRIPT_RUN stage

Which issue(s) this PR fixes:

Part of #5438

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.26%. Comparing base (bcdba1f) to head (3e6c3cd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5439      +/-   ##
==========================================
+ Coverage   26.25%   26.26%   +0.01%     
==========================================
  Files         452      452              
  Lines       48860    48860              
==========================================
+ Hits        12827    12834       +7     
+ Misses      35008    35003       -5     
+ Partials     1025     1023       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) December 23, 2024 01:58
@khanhtc1202
Copy link
Member Author

We considered to stop this this time 👍

auto-merge was automatically disabled December 23, 2024 06:37

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants