Make k8s plugin fields private #5441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
because it does not treat either the workloads are changed or not Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5441 +/- ##
=======================================
Coverage 26.24% 26.24%
=======================================
Files 452 452
Lines 48860 48864 +4
=======================================
+ Hits 12821 12823 +2
- Misses 35014 35016 +2
Partials 1025 1025 ☔ View full report in Codecov by Sentry. |
Warashi
commented
Dec 23, 2024
| } | ||
| got := findWorkloadManifests(manifests, tt.refs) | ||
| assert.ElementsMatch(t, tt.want, got) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestFindUpdatedWorkloads(t *testing.T) { |
There was a problem hiding this comment.
These tests are moved to the provider package.
Comment on lines
-237
to
-255
| { | ||
| name: "manifest with non-string image field", | ||
| manifests: []string{ | ||
| ` | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: non-string-image-deployment | ||
| spec: | ||
| template: | ||
| spec: | ||
| containers: | ||
| - name: nginx | ||
| image: 12345 | ||
| `, | ||
| }, | ||
| want: nil, | ||
| wantErr: true, | ||
| }, |
There was a problem hiding this comment.
This test case is an irregular case, and it's not critical. So I removed it.
Comment on lines
-272
to
-287
| { | ||
| name: "manifest with invalid containers field -- returns error", | ||
| manifests: []string{ | ||
| ` | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: no-containers-deployment | ||
| spec: | ||
| template: | ||
| spec: | ||
| containers: "invalid-containers-field" | ||
| `, | ||
| }, | ||
| wantErr: true, | ||
| }, |
There was a problem hiding this comment.
This test case is an irregular case, and it's not critical. So I removed it.
Warashi
commented
Dec 23, 2024
Comment on lines
+27
to
+28
| key ResourceKey | ||
| body *unstructured.Unstructured |
There was a problem hiding this comment.
This is what I want to do.
Comment on lines
+69
to
+72
| apiVersion string | ||
| kind string | ||
| namespace string | ||
| name string |
There was a problem hiding this comment.
This is also what I want to do.
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
t-kikuc
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
findUpdatedWorkloadsandfindConfigsAndSecretsto provider packagefindUpdatedWorkloadstoFindSameManifestsbecause this function does not see whether the manifests are updated or not.provider.FindContainerImagesand use it indetermineVersionsdetermineVersionsfrom provider.Manifest.BodyWhy we need it:
To restrict updates of field values.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: