-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy .git in deploysource provider #5442
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5442 +/- ##
=======================================
Coverage 26.25% 26.26%
=======================================
Files 452 452
Lines 48860 48842 -18
=======================================
Hits 12827 12827
+ Misses 35008 34990 -18
Partials 1025 1025 ☔ View full report in Codecov by Sentry. |
@Warashi
The script run stage executes commands on the app dir, which is not necessarily the project root. |
@ffjlabo |
@Warashi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What this PR does:
This PR partially reverts #5412.
Why we need it:
In #5412, I implemented that the piped does not copy
.git
in the deploysource provider'scopy
method.This made a breaking change on the SCRIPT_RUN stage.
Before #5412, we can use the
git
command to retrieve manifest repository information.After #5412, we cannot do that because there is not
.git
.In #5412, I implemented the git client to use
git worktree
to clone from the locally cached git repository, so it's a small cost to copy the.git
because it's a small text file.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: