-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wait] Implemented the core of executing Wait with WaitStageOptions #5456
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5456 +/- ##
==========================================
+ Coverage 26.13% 26.17% +0.04%
==========================================
Files 457 458 +1
Lines 49107 49180 +73
==========================================
+ Hits 12835 12875 +40
- Misses 35250 35282 +32
- Partials 1022 1023 +1 ☔ View full report in Codecov by Sentry. |
"testing" | ||
"time" | ||
|
||
config "github.com/pipe-cd/pipecd/pkg/configv1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be here, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khanhtc1202
Thanks, I fixed them: 2be9e5d
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
I imported the rename PR(#5462) to this PR. |
What this PR does:
WaitStageOptions
execute()
of WaitTODO:
SkipOn
optionsWhy we need it:
Which issue(s) this PR fixes:
Part of #5367
Does this PR introduce a user-facing change?: