Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fail_on_error in the lint/go workflow #5460

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Dec 27, 2024

What this PR does:

set fail_on_error option on reviewdog action.

Why we need it:

to notice there are errors.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.13%. Comparing base (ab37feb) to head (16e6908).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5460      +/-   ##
==========================================
- Coverage   26.14%   26.13%   -0.02%     
==========================================
  Files         457      457              
  Lines       49107    49107              
==========================================
- Hits        12841    12835       -6     
- Misses      35244    35250       +6     
  Partials     1022     1022              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi marked this pull request as ready for review December 27, 2024 04:03
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Warashi Warashi merged commit 6e98705 into master Dec 27, 2024
17 of 18 checks passed
@Warashi Warashi deleted the workflow-lint-go-ensure-fail branch December 27, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants