Add MetadataStore methods to PipedService #5469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
Warashi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5469 +/- ##
=======================================
Coverage 26.19% 26.19%
=======================================
Files 458 458
Lines 49169 49169
=======================================
Hits 12881 12881
Misses 35266 35266
Partials 1022 1022 ☔ View full report in Codecov by Sentry. |
Warashi
reviewed
Jan 8, 2025
Comment on lines
122
to
124
| message PutStageMetadataResponse { | ||
| bool success = 1; | ||
| } |
There was a problem hiding this comment.
We don't need success field because we can return error as gRPC error.
Signed-off-by: t-kikuc <[email protected]>
|
@khanhtc1202 Would you please approve again? |
khanhtc1202
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Added the following MetadataStore methods to PipedService:
Why we need it:
Plugins need to Read/Write metadata in Piped-side for the following use cases:
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: