Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MigrateDatabase RPC to APIService for database migration #5476

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Jan 14, 2025

What this PR does:

as title

Why we need it:

When developing pipedv1, we have to use data with new fields, such as deploy target, or we have to patch pipedv1 temporarily to use the old field.
This PR defines the API to convert the existing data to prepare the data with new fields.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@Warashi Warashi marked this pull request as ready for review January 14, 2025 06:02
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.18%. Comparing base (6a0e67e) to head (a94b235).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5476      +/-   ##
==========================================
- Coverage   26.19%   26.18%   -0.02%     
==========================================
  Files         458      458              
  Lines       49172    49172              
==========================================
- Hits        12881    12875       -6     
- Misses      35267    35273       +6     
  Partials     1024     1024              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit 786bf3d into master Jan 20, 2025
17 of 18 checks passed
@Warashi Warashi deleted the database-migration branch January 20, 2025 06:22
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants