Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sync / rollback method to the separate file #5479

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Jan 17, 2025

What this PR does:

Move implementation of K8S_SYNC and K8S_ROLLBACK to separate files.

Why we need it:

To improve readability.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 40.22989% with 104 lines in your changes missing coverage. Please review.

Project coverage is 26.23%. Comparing base (025936b) to head (7a54aff).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...p/pipedv1/plugin/kubernetes/deployment/rollback.go 0.00% 60 Missing ⚠️
...g/app/pipedv1/plugin/kubernetes/deployment/sync.go 61.40% 34 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5479      +/-   ##
==========================================
- Coverage   26.24%   26.23%   -0.01%     
==========================================
  Files         458      460       +2     
  Lines       49370    49370              
==========================================
- Hits        12956    12952       -4     
- Misses      35386    35389       +3     
- Partials     1028     1029       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi marked this pull request as ready for review January 17, 2025 01:56
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

more readable!

@Warashi Warashi enabled auto-merge (squash) January 17, 2025 02:07
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Warashi Warashi merged commit 56c12df into master Jan 17, 2025
18 checks passed
@Warashi Warashi deleted the k8s-plugin-refactor-move-methods-to-separate-file branch January 17, 2025 02:15
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants