Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeployTargets when building a deployment #5496

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Jan 20, 2025

What this PR does:

as title

Why we need it:

We use the DeployTargets field in the Deployment model when executing the deployment.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@Warashi Warashi marked this pull request as ready for review January 20, 2025 06:05
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.24%. Comparing base (8ce5252) to head (f0d50fd).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/piped/trigger/deployment.go 0.00% 1 Missing ⚠️
pkg/app/pipedv1/trigger/deployment.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5496   +/-   ##
=======================================
  Coverage   26.23%   26.24%           
=======================================
  Files         460      460           
  Lines       49370    49372    +2     
=======================================
+ Hits        12952    12956    +4     
+ Misses      35389    35388    -1     
+ Partials     1029     1028    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit f8c56db into master Jan 22, 2025
17 of 18 checks passed
@Warashi Warashi deleted the copy-deploy-target-when-build-deployment branch January 22, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants