Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: Remove old 'planner' comments #5505

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jan 22, 2025

What this PR does:

Removed Package planner provides a piped component... comments from pkg/plugin/.* files.

Why we need it:

They are not planner packages. (migrated from planner)

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@t-kikuc t-kikuc enabled auto-merge (squash) January 22, 2025 03:57
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.27%. Comparing base (e0dfc18) to head (3af36ec).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5505      +/-   ##
==========================================
- Coverage   26.28%   26.27%   -0.01%     
==========================================
  Files         464      464              
  Lines       49624    49626       +2     
==========================================
- Hits        13043    13041       -2     
- Misses      35547    35552       +5     
+ Partials     1034     1033       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@t-kikuc t-kikuc merged commit 3955869 into master Jan 22, 2025
15 of 18 checks passed
@t-kikuc t-kikuc deleted the nit-remove-old-comment-planner branch January 22, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants