Skip to content

Fix livestatereporter to consider multiple plugins in one app #3838

Fix livestatereporter to consider multiple plugins in one app

Fix livestatereporter to consider multiple plugins in one app #3838

GitHub Actions / golangci failed Dec 26, 2024 in 1s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (2)

pkg/app/pipedv1/cmd/piped/piped.go|370 col 38| cannot use applicationLister (variable of type applicationstore.Lister) as livestatereporter.applicationLister value in argument to livestatereporter.NewReporter: applicationstore.Lister does not implement livestatereporter.applicationLister (missing method ListByPluginName)) (typecheck)
pkg/app/pipedv1/cmd/piped/piped.go|370 col 38| cannot use applicationLister (variable of type applicationstore.Lister) as livestatereporter.applicationLister value in argument to livestatereporter.NewReporter: applicationstore.Lister does not implement livestatereporter.applicationLister (missing method ListByPluginName) (typecheck)

Filtered Findings (0)

Annotations

Check failure on line 370 in pkg/app/pipedv1/cmd/piped/piped.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/app/pipedv1/cmd/piped/piped.go#L370

cannot use applicationLister (variable of type applicationstore.Lister) as livestatereporter.applicationLister value in argument to livestatereporter.NewReporter: applicationstore.Lister does not implement livestatereporter.applicationLister (missing method ListByPluginName)) (typecheck)
Raw output
pkg/app/pipedv1/cmd/piped/piped.go:370:38: cannot use applicationLister (variable of type applicationstore.Lister) as livestatereporter.applicationLister value in argument to livestatereporter.NewReporter: applicationstore.Lister does not implement livestatereporter.applicationLister (missing method ListByPluginName)) (typecheck)
	"github.com/pipe-cd/pipecd/pkg/app/pipedv1/cmd/piped"
	^

Check failure on line 370 in pkg/app/pipedv1/cmd/piped/piped.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/app/pipedv1/cmd/piped/piped.go#L370

cannot use applicationLister (variable of type applicationstore.Lister) as livestatereporter.applicationLister value in argument to livestatereporter.NewReporter: applicationstore.Lister does not implement livestatereporter.applicationLister (missing method ListByPluginName) (typecheck)
Raw output
pkg/app/pipedv1/cmd/piped/piped.go:370:38: cannot use applicationLister (variable of type applicationstore.Lister) as livestatereporter.applicationLister value in argument to livestatereporter.NewReporter: applicationstore.Lister does not implement livestatereporter.applicationLister (missing method ListByPluginName) (typecheck)
// Copyright 2024 The PipeCD Authors.