Don't show already hidden tab preview tooltip on updated

piroor · Nov 29, 2024 · 7609de9 · 7609de9
1 parent bcaf1e6
commit 7609de9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/webextensions/resources/tab-preview-frame.js b/webextensions/resources/tab-preview-frame.js
@@ -180,8 +180,8 @@ try{
     switch (message?.type) {
       case 'treestyletab:update-tab-preview':
         if (!panel ||
-            (message.tabId &&
-             panel.dataset.tabId != message.tabId)) {
+            panel.dataset.tabId != message.tabId ||
+            panel.classList.contains('hidden')) {
           return;
         }
       case 'treestyletab:show-tab-preview':

diff --git a/webextensions/sidebar/tab-preview-tooltip.js b/webextensions/sidebar/tab-preview-tooltip.js
@@ -243,8 +243,8 @@ async function sendTabPreviewMessage(tabId, message, deferredReturnedValueResolv
     return promisedReturnedValue;
   }
 
-  if (!returnValue) {
-    // Failed to show in-content tab preview, so
+  if (typeof returnValue != 'boolean') {
+    // Failed to send message to the in-content tab preview frame, so
     // now we fall back to the in-sidebar tab preview.
     return sendInSidebarTabPreviewMessage(message);
   }