Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stemcell-slug option to download-product command #682

Merged
merged 5 commits into from
Mar 6, 2025
Merged

add stemcell-slug option to download-product command #682

merged 5 commits into from
Mar 6, 2025

Conversation

yharish991
Copy link
Contributor

@yharish991 yharish991 commented Feb 28, 2025 •
edited
Loading

This PR adds a stemcell-slug optinal option to download-product command to specify the stemcell slug in case of multiple stemcells

@yharish991 yharish991 marked this pull request as draft February 28, 2025 16:27
@yharish991 yharish991 marked this pull request as ready for review February 28, 2025 18:28
@yharish991 yharish991 requested a review from drich10 February 28, 2025 18:28
wayneadams
wayneadams approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@wayneadams wayneadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

download_clients/pivnet_client_test.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great new tests!

drich10
drich10 requested changes Mar 4, 2025
View reviewed changes
Copy link
Member

@drich10 drich10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Just a few changes would make the new logic a bit easier to parse for our future selves

@yharish991 yharish991 requested a review from drich10 March 5, 2025 16:12
drich10
drich10 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@drich10 drich10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates and lgtm!

@yharish991 yharish991 merged commit 7f3a0c7 into main Mar 6, 2025
1 check passed
@yharish991 yharish991 deleted the stemcell-slug branch March 6, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drich10 drich10 drich10 approved these changes

@wayneadams wayneadams wayneadams approved these changes

@ichandrabhatta ichandrabhatta Awaiting requested review from ichandrabhatta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yharish991 @drich10 @wayneadams