fix: mobile menu icon x issue resolved #1077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @piyushgarg-dev on Vercel. @piyushgarg-dev first needs to authorize it. |
nepalivai
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
after opening the menu in mobile view ,the closing icon "X" shows and when we switched to desktop view it disappares
when we switched to mobile view the navbar is by default close
Fixes #1065
x_issue2.mp4
Type of change
How should this be tested?
Go to 'inspect mode'
Switch mobile view
Click on the 'navigation bar'
Don't close it
Switch switch back to laptop view/ close inspect mode
See no error