fix: reuse-social-media-links-accross-header-footer #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@awadheshgupta1 is attempting to deploy a commit to the Piyush Garg's projects Team on Vercel. A member of the Team first needs to authorize it. |
ad-gupta
changed the title
ad-gupta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Earlier code was hardcoded with separate components of different social media access, I combine all data into a list and map all links to render all social media links.
Fixes #1838
Type of change
Changes made in code and also used best practice of design
How should this be tested?
Go to home page
Check Navbar and Contact (Footer) social media links
Mandatory Tasks
Checklist