Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fix integration tests locally #221

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wesleytodd
Copy link
Member

Fixes integration tests for local development. I am not sure if these were running in CI but I am guessing if they were it was working because of some accidental setup not because they were correctly written. This fixes them locally for me and the PR will see if they run in CI and if so if these fixes also work in that environment.

@wesleytodd
Copy link
Member Author

wesleytodd commented Feb 24, 2025

I guess they were not running. As I am looking back on these, they were written way before I even moved this into the pkgjs org, so my guess is they were never working after that which is why the changes made since then were broken in the tests.

Anyway, because there is so much business logic in run.js which is intended to be run only with the actions environment, I believe we would need to use ACT to run a true integration tests for these. I am not a fan of that and would rather move logic into testable units. Sooo, while this is probably something we could merge, I am not sure of the value on it's own. I am not going to spend too much more time on this today, but will open a PR to fix the actual issue I was doing this to debug and we can decide if keeping these integration tests around is even worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant