add the option to choose which branch to test #151
Conversation
bjohansebas
changed the title
bin/commands/result.js
Outdated
| .option('branch', { | ||
| desc: 'Branch that was chosen for testing', | ||
| type: 'string', | ||
| conflicts: 'config' |
There was a problem hiding this comment.
why would this conflict with config? Id expect the config to be overridden by command line flags
There was a problem hiding this comment.
I was just following how the other options were programmed, although what you're saying makes sense.
bjohansebas
changed the title
ljharb
force-pushed
the
option-branch
branch
from
a1800a5 to
7d0e564
Compare
bin/commands/result.js
Outdated
| @@ -18,7 +22,7 @@ exports.builder = (yargs) => yargs | |||
| exports.handler = async (params) => { | |||
| const config = params.dependent | |||
| ? { | |||
| dependents: [{ repository: params.dependent }] | |||
| dependents: [{ repository: params.dependent, branch: params?.branch || 'HEAD' }] | |||
There was a problem hiding this comment.
either params.dependent needs optional chaining, or params.branch doesn't
bin/commands/test.js
Outdated
| @@ -24,7 +28,7 @@ exports.builder = (yargs) => yargs | |||
| exports.handler = (params) => { | |||
| const config = params.dependent | |||
| ? { | |||
| dependents: [{ repository: params.dependent, pullRequest: !!params['pull-request'] }] | |||
| dependents: [{ repository: params.dependent, pullRequest: !!params['pull-request'], branch: params?.branch || "HEAD" }] | |||
There was a problem hiding this comment.
either params.dependent and params['pull-request'] both need optional chaining, or params.branch doesn't
|
Optional chaining is not available for Node 12 :( |
|
but the pre-existing code also suggests it's not needed. maybe it's just IDE types that are wrong? |
bjohansebas
force-pushed
the
option-branch
branch
from
7d0e564 to
30d1bb7
Compare
|
Probably |
bjohansebas
force-pushed
the
option-branch
branch
from
d9e235a to
715d9d5
Compare
|
I don't understand why it doesn't work for Node 12 now, there hasn't been any change that should break compatibility. |
|
try rebasing instead of merging and force push? |
|
I've found the error :) |
…arameter and replace package.json query
bjohansebas
force-pushed
the
option-branch
branch
from
f0ecdf9 to
b870df3
Compare
bjohansebas
force-pushed
the
option-branch
branch
from
8ae80a0 to
586c9e3
Compare
The option to choose which branch to use as a reference for testing is added, as the main branch will not always be the one selected.