pkp/pkp-lib#11318 Bug fix, Don't mix revisions for different file types #11341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jardakotesovec
commented
Apr 29, 2025
| @@ -217,6 +217,7 @@ public function getSubmissionFiles() | |||
| ->getCollector() | |||
| ->filterByReviewRoundIds([(int) $reviewRound->getId()]) | |||
| ->filterBySubmissionIds([$submissionId]) | |||
| ->filterByFileStages([(int) $this->getData('fileStage')]) | |||
| ->getMany() | |||
There was a problem hiding this comment.
This make sure that we list only from the same "file grid" for the "If you are uploading a revision of an existing file, please indicate which file."
jardakotesovec
commented
Apr 29, 2025
| @@ -262,7 +263,7 @@ public function getRevisionSubmissionFilesSelection($user, $uploadedFile = null) | |||
| } | |||
| if ( | |||
| ($submissionFile->getFileStage() == SubmissionFile::SUBMISSION_FILE_REVIEW_ATTACHMENT || $submissionFile->getFileStage() == SubmissionFile::SUBMISSION_FILE_REVIEW_FILE) && | |||
| $stageAssignmentDao->getBySubmissionAndRoleIds($submissionFile->getData('submissionId'), [Role::ROLE_ID_AUTHOR], $this->getStageId(), $user->getId()) | |||
| $stageAssignmentDao->getBySubmissionAndRoleIds($submissionFile->getData('submissionId'), [Role::ROLE_ID_AUTHOR], $this->getStageId(), $user->getId())->next() | |||
| ) { | |||
There was a problem hiding this comment.
This is fix, to make this condition working as intended. But not sure if thats necessary anymore. As the logic seemed that getSubmissionFiles would return ALL files for given review round. And than the exclusions made sense to not expose some of these files to the Author. But if getSubmissionFiles is now returning just the same fileType, I don't think thats necessary. But keeping the changes minimum due to my limited understanding of this area :-).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.